Fix: Redundant error notifications on block explorer #775
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
technophile-04
approved these changes
Mar 13, 2024
Collaborator
technophile-04
left a comment
technophile-04
left a comment
There was a problem hiding this comment.
This PR breaks up the useEffect that checks for targetNetwork and error. It also adds in 2 new useState hooks to control the triggering of error notifications.
Nice ! makes sense, Tysm @ChangoMan for tackling it 🙌
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
toasterror notifications that are onblockexplorer/page.tsxwill currently render 3-4 times on the initial page visit. If you reload the page and there are errors, it will keep spamming the toast notifications.This PR breaks up the
useEffectthat checks fortargetNetworkanderror. It also adds in 2 newuseStatehooks to control the triggering of error notifications.BEFORE:
Screen.Recording.2024-03-13.at.12.07.52.AM.mov
AFTER:
Screen.Recording.2024-03-13.at.12.06.35.AM.mov
Additional Information